-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vis-violin): violin vis subcategories and proper facets #331
Conversation
…to mh/visinnovation
rafactor axis label color, position refactor tick label, color hide border refactor selection colors (gray when not selected)
- remove unused vectorv3 file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. I just made a tiny change, pulling the traces color into a constant. Otherwise, it looks good to me. I tested several permutations of the violin plot. And with the addition of the new breast cancer sample dataset, everything worked nicely (also some columns with missing data).
@dvmartinweigl thanks for this PR, I have a few minor comments: |
Violin plot stories are currently broken, this will be addressed in a follow-up ticket: #345 |
|
… mweigl/violin-vis-grouping
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your final changes. The last issue that caused the violin plot not to be shown in Ordino now properly works. From my point of view, this PR can now be merged.
## What's changed * feat(vis): align visual appearance, rotate bar plot axis labels, add vis hooks, remove raincloud plot (#293) * feat(vis-violin): violin vis subcategories and proper facets (#331) * feat: add console integration for Sentry (#347) * feat: add boxplot vis type (#302) * deps: upgrade deps to latest versions (20240611) (#344) * feat(vis): add column description to selects and pills (#358) * feat: lazy load plotly where possible (#346) * feat: add BlurredOverlay component (#359) * Fix: export vis color and fix y-axis label (#360)
Closes https://github.com/datavisyn/bioinsight/issues/437
Developer Checklist (Definition of Done)
Issue
UI/UX/Vis
Code
PR
release: minor
) to this PR following semverCloses #...
)Summary of changes
Screenshots
Additional notes for the reviewer(s)
Thanks for creating this pull request 🤗